fix: use placeholder for artifact/cache server address in man page#6051
Open
xingzihai wants to merge 1 commit intonektos:masterfrom
Open
fix: use placeholder for artifact/cache server address in man page#6051xingzihai wants to merge 1 commit intonektos:masterfrom
xingzihai wants to merge 1 commit intonektos:masterfrom
Conversation
The default values for --artifact-server-addr and --cache-server-addr were calling GetOutboundIP() during flag definition, which embedded the actual outbound IP address in the generated man page. This made the package non-reproducible and had privacy concerns. Changed the flag defaults to empty string and added runtime auto-detection logic in newRunCommand to compute the outbound IP when the values are empty. This ensures: - Man pages are reproducible (show empty string as default) - Privacy is preserved (no IP in documentation) - Runtime behavior is preserved (IP is auto-detected when needed) Fixes: nektos#5894
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default values for
--artifact-server-addrand--cache-server-addrwere callingGetOutboundIP()during flag definition, which embedded the actual outbound IP address in the generated man page.This causes:
From the issue:
Solution
Changed the flag defaults to empty string and added runtime auto-detection logic in
newRunCommandto compute the outbound IP when the values are empty.This ensures:
Changes
--artifact-server-addrflag default fromcommon.GetOutboundIP().String()to empty string--cache-server-addrflag default fromcommon.GetOutboundIP().String()to empty stringnewRunCommandto compute the IP if either address is emptyFixes: #5894