docs: add "Choosing a pattern" section to K8s getting started#811
docs: add "Choosing a pattern" section to K8s getting started#811SunsetDrifter wants to merge 1 commit into
Conversation
Add a decision table and rules of thumb covering routing peer vs client sidecar vs API server proxy vs Gateway API, so readers can pick the right operator pattern. Clarifies that a sidecar (not a routing peer) is the answer when a pod needs its own identity or to originate traffic onto the overlay.
📝 WalkthroughWalkthroughA new "Choosing a pattern" section is added to the Kubernetes operator integration documentation. It includes a comparison table of the four connection patterns, a rules-of-thumb bullet list for selecting among them, and a note about NetBird's deny-by-default behavior requiring users to create an explicit access policy. ChangesKubernetes Operator Integration Docs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/pages/manage/integrations/kubernetes/index.mdxOops! Something went wrong! :( ESLint: 9.39.4 TypeError: Converting circular structure to JSON Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/pages/manage/integrations/kubernetes/index.mdx (1)
50-52: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMinor: Consider tightening the introductory sentence.
Line 52 uses "rather than competing with each other," which is clear but slightly verbose. Given the "Chill" review strictness and the phrasing's pedagogical value (emphasizing complementarity), this is optional—feel free to keep it as-is for readability.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/manage/integrations/kubernetes/index.mdx` around lines 50 - 52, In the "Choosing a pattern" section, the introductory sentence contains the verbose phrase "rather than competing with each other" which could be tightened for clarity. Consider removing or rephrasing this phrase while preserving the key pedagogical message that these are complementary approaches that answer different questions based on what you're exposing and whether each workload needs its own identity.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/manage/integrations/kubernetes/index.mdx`:
- Around line 54-59: The Badge component used on line 59 in the diff is
currently imported from an incorrect source according to coding guidelines.
Locate the import statement for the Badge component (currently importing from
`@/components/Badge`) on line 29 and update it to import from `@/components/mdx`
instead. This ensures all component imports comply with the established coding
standards for this project.
---
Nitpick comments:
In `@src/pages/manage/integrations/kubernetes/index.mdx`:
- Around line 50-52: In the "Choosing a pattern" section, the introductory
sentence contains the verbose phrase "rather than competing with each other"
which could be tightened for clarity. Consider removing or rephrasing this
phrase while preserving the key pedagogical message that these are complementary
approaches that answer different questions based on what you're exposing and
whether each workload needs its own identity.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 198d9194-0fe2-40ca-a0b0-43064470aa8d
📒 Files selected for processing (1)
src/pages/manage/integrations/kubernetes/index.mdx
|
|
||
| | Pattern | Exposes | Identity | Reach it via | Best for | | ||
| |---|---|---|---|---| | ||
| | [Routing Peer](/manage/integrations/kubernetes/routing-peer) | a `ClusterIP` Service | a shared routing peer | DNS name (`service.namespace.zone`) | stable internal services (databases, APIs) that many peers reach | |
There was a problem hiding this comment.
The resource in the operator is called a NetworkRouter. Maybe good to stick with that?
There was a problem hiding this comment.
Also the dns name is not correct. It is the zone set in the Network router itself.
Summary
Adds a Choosing a pattern section to the Kubernetes operator Getting Started page. After installing the operator, readers face several ways to connect a cluster (routing peer, client sidecar, API server proxy, Gateway API) and currently have no guidance on which to pick. This section makes that choice explicit.
It adds:
Changes
src/pages/manage/integrations/kubernetes/index.mdx— new## Choosing a patternsection (+23 lines).Note
The routing-peer row links to the
use-cases/route-to-a-kubernetes-servicehow-to, which is added in a separate PR. Merge that one first (or together) so the link resolves.Summary by CodeRabbit