Skip to content

[NAE-2416] AbstractFileDefaultFieldComponent does not push upload event #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machacjozef merged 12 commits into from
May 19, 2026
+244 −111

Refactor file upload logic to improve readability

26c66aa
Select commit
Loading
Failed to load commit list.
Merged

[NAE-2416] AbstractFileDefaultFieldComponent does not push upload event #326

Refactor file upload logic to improve readability
26c66aa
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 19, 2026 in 1m 7s

Quality Gate failed

Failed conditions
16.7% Coverage on New Code (required ≥ 50%)
11.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 254 in projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ3O0hl5cCPq9sm4VVs5&open=AZ3O0hl5cCPq9sm4VVs5&pullRequest=326

Check warning on line 60 in projects/netgrif-components-core/src/lib/event/services/event.service.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Redundant double negation. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ3T68Rs_jNLujW619wa&open=AZ3T68Rs_jNLujW619wa&pullRequest=326

Check warning on line 457 in projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'(next?: (value: Blob | ProviderProgress) => void, error?: (error: any) => void, complete?: () => void): Subscription' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ3O0hl5cCPq9sm4VVs8&open=AZ3O0hl5cCPq9sm4VVs8&pullRequest=326

Check warning on line 201 in projects/netgrif-components-core/src/lib/data-fields/file-list-field/file-list-default-field/abstract-file-list-default-field.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ3O0houcCPq9sm4VVs-&open=AZ3O0houcCPq9sm4VVs-&pullRequest=326

Check warning on line 254 in projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Redundant double negation. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ3O0hl5cCPq9sm4VVs6&open=AZ3O0hl5cCPq9sm4VVs6&pullRequest=326

Check warning on line 201 in projects/netgrif-components-core/src/lib/data-fields/file-list-field/file-list-default-field/abstract-file-list-default-field.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Redundant double negation. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ3O0houcCPq9sm4VVs_&open=AZ3O0houcCPq9sm4VVs_&pullRequest=326

Check warning on line 36 in projects/netgrif-components-core/src/lib/utility/tests/mocks/mock-task-resource.service.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ46BpwY_44ISY7VzH-i&open=AZ46BpwY_44ISY7VzH-i&pullRequest=326

Check warning on line 421 in projects/netgrif-components-core/src/lib/data-fields/file-field/file-default-field/abstract-file-default-field.component.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'(next?: (value: Blob | ProviderProgress) => void, error?: (error: any) => void, complete?: () => void): Subscription' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ3O0hl5cCPq9sm4VVs7&open=AZ3O0hl5cCPq9sm4VVs7&pullRequest=326
View more details on SonarQubeCloud