Repository navigation
test: normalize the Windows fallback for the answered-prompt tick - #8559
Merged
Merged
Conversation
@inquirer/prompts marks answered prompts with ✔, but uses √ when it detects a terminal without Unicode support. On Windows that detection relies on env vars such as TERM or WT_SESSION, which the env:list integration tests strip (extendEnv: false), so their snapshots failed on the Windows runners. Normalize ✔ to √ like the existing ❯ to > rule.
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
JakeChampion
approved these changes
Oct 5, 2026
paulo
enabled auto-merge (squash)
October 5, 2026 08:09
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This unblocks the release. The release PR's integration run fails on Windows (
windows-2025, shard 2/4) in twoenv:listsnapshot tests:Cause: since #8551, prompts come from
@inquirer/prompts. It marks answered prompts with✔, but switches to√when it detects a terminal without Unicode support. On Windows it decides that from environment variables such asTERMorWT_SESSION. Theenv:listtests start the CLI withextendEnv: falseand onlyPATH/HOME/APPDATA, so on Windows they get√, while the snapshots were recorded on macOS with✔. The framework-detection prompt test passes on Windows because it inherits the runner's environment. Pull-request integration checks run only on Ubuntu, so this first appeared in the release run.Fix: the snapshot normalizer already maps
❯to its Windows fallback>. This adds the same rule for✔→√and updates the three snapshot lines that contain✔.How this was verified
envandframework-detectionintegration tests pass on macOS (40/40).@inquirer/figuresalso falls back whenTERM=linux. I temporarily set that on the twoenv:listtests (not committed).