Skip to content

chore(eslint): use eslint's native bulk suppressions instead of custom #8587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhalp merged 5 commits into from
Oct 8, 2026
Merged

chore(eslint): use eslint's native bulk suppressions instead of custom #8587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1789f8c
chore(eslint): use eslint's native bulk suppressions instead
serhalp Oct 7, 2026
89f27a4
chore(eslint): disable n/hashbang in one file
serhalp Oct 7, 2026
3f7b011
chore(eslint): fix autofixable suppressed rules
serhalp Oct 7, 2026
93f3021
Merge branch 'main' into serhalp/chore/eslint-bulk-suppressions
serhalp Oct 7, 2026
bc007d2
Merge branch 'main' into serhalp/chore/eslint-bulk-suppressions
serhalp Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .oxfmtrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"semi": false,
"singleQuote": true,
"sortPackageJson": true,
"ignorePatterns": ["node_modules", "CHANGELOG.md", "docs/**", "**/package-lock.json"]
"ignorePatterns": ["node_modules", "CHANGELOG.md", "docs/**", "**/package-lock.json", "eslint-suppressions.json"]
}
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@
npm run lint:fix
```

Pre-existing lint violations are tracked in `eslint-suppressions.json` using ESLint's

Check warning on line 77 in CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / lint-docs 

[vale] reported by reviewdog 🐶
[smart-marks.smartApostrophes] Use a smart apostrophe (’) instead of a straight single quote mark in 'ESLint's'

Raw Output:
{"message": "[smart-marks.smartApostrophes] Use a smart apostrophe (’) instead of a straight single quote mark in 'ESLint's'", "location": {"path": "CONTRIBUTING.md", "range": {"start": {"line": 77, "column": 78}}}, "severity": "WARNING"}

Check warning on line 77 in CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / lint-docs 

[vale] reported by reviewdog 🐶
[base.spelling] Spellcheck: did you really mean 'ESLint's'?

Raw Output:
{"message": "[base.spelling] Spellcheck: did you really mean 'ESLint's'?", "location": {"path": "CONTRIBUTING.md", "range": {"start": {"line": 77, "column": 78}}}, "severity": "WARNING"}
[bulk suppressions](https://eslint.org/docs/latest/use/suppressions). When you fix a suppressed violation, run

Check warning on line 78 in CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / lint-docs 

[vale] reported by reviewdog 🐶
[base.spelling] Spellcheck: did you really mean 'suppressions'?

Raw Output:
{"message": "[base.spelling] Spellcheck: did you really mean 'suppressions'?", "location": {"path": "CONTRIBUTING.md", "range": {"start": {"line": 78, "column": 7}}}, "severity": "WARNING"}
`npx eslint --prune-suppressions` to remove the stale entry (ESLint fails until you do). Please don't add new

Check warning on line 79 in CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / lint-docs 

[vale] reported by reviewdog 🐶
[smart-marks.smartApostrophes] Use a smart apostrophe (’) instead of a straight single quote mark in 'don't'

Raw Output:
{"message": "[smart-marks.smartApostrophes] Use a smart apostrophe (’) instead of a straight single quote mark in 'don't'", "location": {"path": "CONTRIBUTING.md", "range": {"start": {"line": 79, "column": 97}}}, "severity": "WARNING"}

Check warning on line 79 in CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / lint-docs 

[vale] reported by reviewdog 🐶
[base.spelling] Spellcheck: did you really mean 'ESLint'?

Raw Output:
{"message": "[base.spelling] Spellcheck: did you really mean 'ESLint'?", "location": {"path": "CONTRIBUTING.md", "range": {"start": {"line": 79, "column": 62}}}, "severity": "WARNING"}
suppressions.

Check warning on line 80 in CONTRIBUTING.md

View workflow job for this annotation

GitHub Actions / lint-docs 

[vale] reported by reviewdog 🐶
[base.spelling] Spellcheck: did you really mean 'suppressions'?

Raw Output:
{"message": "[base.spelling] Spellcheck: did you really mean 'suppressions'?", "location": {"path": "CONTRIBUTING.md", "range": {"start": {"line": 80, "column": 1}}}, "severity": "WARNING"}

To run the CLI locally:

```bash
Expand Down
Loading
Loading