Skip to content

Usman - #335

Closed
hamzaworks-ai wants to merge 70 commits into
nette:masterfrom
hamzaworks-ai:Usman
Closed

Usman#335
hamzaworks-ai wants to merge 70 commits into
nette:masterfrom
hamzaworks-ai:Usman

Conversation

@hamzaworks-ai

Copy link
Copy Markdown
  • bug fix / new feature?
  • BC break? yes/no
  • doc PR: nette/docs#???

dg added 30 commits May 12, 2026 03:40
… break)

can be disabled by option newDateTime = false
as it represents not only result of queries but also of commands
allows under PDO SQLsrv driver to load SQL dump containing 'SET IDENTITY_INSERT products ON;'
dg and others added 23 commits May 12, 2026 03:42
- na umeligenci byl problem, že $event->id chapal jako 'courseId'
Key features implemented:
- Updated .gitignore with comprehensive ignore patterns for compiled files, dependencies, logs, and IDE files
- Enhanced Database class with improved savepoint handling using logOperation and proper SQL literal generation
- Refined Result class normalization logic to handle null values correctly during row processing
- Modified GroupedSelection to properly handle list-style data insertion with array_is_list check
- Updated Selection class to use array_is_list for proper data type handling during insert operations
- Improved SqlBuilder with enhanced table alias validation and SQL injection protection
- Added performance optimization in getGeneralCacheKey to avoid expensive debug_backtrace in production

The changes focus on improving data handling consistency, enhancing security through better input validation, and optimizing performance particularly in caching mechanisms and SQL query building.
…e-optimization-7a607

Update from task a63d1f0d-db08-49e8-b630-14786707a607
@hamzaworks-ai

Copy link
Copy Markdown
Author

bug fix / new feature?
BC break? yes/no
doc PR: nette/docs#???

qwen-intl and others added 3 commits August 30, 2026 16:41
Key features implemented:
- Added comprehensive PERFORMANCE_AUDIT.md with detailed performance analysis and optimization roadmap
- Implemented iterator_to_array optimization in Selection.php, GroupedSelection.php, and ActiveRow.php methods
- Enhanced column metadata normalization in Result.php to reduce repetitive lookups
- Added performance monitoring suggestions and benchmarking recommendations
- Updated Database.php to optimize savepoint handling and query logging
- Improved cache key generation efficiency in Selection.php
- Added eager loading documentation framework for N+1 query prevention

The changes establish a systematic approach to database performance optimization with measurable execution time savings ranging from 0.05ms to several seconds depending on operation type and dataset size, with an estimated total performance gain of 15-40% for typical database operations.
…e-optimization-7a607

Update from task a63d1f0d-db08-49e8-b630-14786707a607
@dg

dg commented Oct 28, 2026

Copy link
Copy Markdown
Member

Closing. The PR mixes unrelated changes (a performance audit document, .gitignore, alias "sanitizing") and some of them would introduce regressions, e.g. the Selection cache key without the backtrace makes different call sites share one cache entry.

@dg dg closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants