229 pgc includes temporary session schemas pg temp when using scheme - #233
Merged
nettrash merged 1 commit intoJul 18, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #229 by preventing PGC’s schema-resolution step (used by dump/compare/clear) from ever selecting PostgreSQL system/temporary session schemas when --scheme is broad (e.g., %), avoiding invalid create schema pg_temp_N output.
Changes:
- Updates schema resolution SQL to exclude all
pg_-prefixed schemas (coverspg_catalog,pg_toast,pg_temp_*,pg_toast_temp_*) while keepinginformation_schemaexcluded. - Refactors the schema-resolution query into a dedicated
Dump::build_schemas_query()helper for reuse/testing. - Adds a unit test asserting the query contains the intended exclusions and updates the CHANGELOG entry for #229.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CHANGELOG | Documents the #229 fix and rationale (exclude pg_-prefixed schemas during schema resolution). |
| app/src/dump/core.rs | Centralizes schema-resolution SQL and applies pg_ prefix exclusion via NOT LIKE 'pg\\_%'. |
| app/src/dump/core_tests.rs | Adds a regression-style test to ensure schema-resolution query excludes pg_ schemas and information_schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nettrash
deleted the
229-pgc-includes-temporary-session-schemas-pg_temp_-when-using---scheme
branch
July 18, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #229