Add AB Stratix support to cisco_ios sh ver#2330
Draft
mjbear wants to merge 7 commits into
Draft
Conversation
* Add Error directive to Stack state * Add uncaptured (ignored) line patterns
* Remove unnecessary trailing \s* * Replace literal spaces with \s+
Being picky for consistency ... and putting capital first in pattern
* Add Error directive to Start state * Add uncaptured patterns to State state Since there's the chance for the copyright or licensing text to change, there's a chance we should remove the Error directive. (But still match some more important lines.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2243
StackstateStackstateStartstateNote: Given the variations in the licensing verbiage, for maintenance reasons we might not want the Error directive in the
Startstate.