apc: expose NMC3 ambient temperature - #3605
Open
user01010111 wants to merge 1 commit into
Open
Conversation
APC Network Management Card 3 units expose universal I/O temperature at uioSensorStatusTemperatureDegC, but the APC subdriver does not map that OID to ambient.temperature. Add the OID as the first ambient provider, reject the MIB's -1 invalid sentinel, bump APCC_MIB_VERSION to 1.62, and document the addition. Fixes networkupstools#3250 Signed-off-by: user01010111 <lapses.50.booster@icloud.com>
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit d0b0293 is temporarily available: NUT-tarballs-PR-3605.zip. |
|
✅ Build nut 2.8.5.5173-master completed (commit bfb14d4b41 by @)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3250.
APC Network Management Card 3 units expose universal I/O temperature through
uioSensorStatusTemperatureDegC, but the APC subdriver does not currently map that value toambient.temperature.This adds the Universal I/O Celsius OID as the first ambient-temperature provider, rejects the MIB-defined
-1invalid sentinel, bumpsAPCC_MIB_VERSIONto1.62, and documents the addition inNEWS.adoc.Schneider Electric's official PowerNet MIB v4.6.0, dated 9 July 2026, independently confirms the exact Celsius OID and the
-1invalid sentinel. Placing the new mapping before the existing Measure-UPS and IEM alternatives lets NMC3 devices use it when legacy OIDs are unavailable while preserving the current later-provider precedence on devices which answer those legacy OIDs.Validation
-Werror: clean completesnmp-upscompile and link passed.-Weverything -Werror: clean completesnmp-upscompile and link passed.-Weverything -Werror.1.62, the exact OID, scale1,SU_FLAG_OK | SU_FLAG_NEGINVALID, and first-provider placement.make stylecheck, non-ASCII checks andgit diff --checkpassed.make SPELLCHECK_ERROR_FATAL=no distcheck-lightpassed, including archive, build, check, install and uninstall.The whole-driver Clang hard profile stops on nine existing conversion warnings in unchanged
snmp-ups.c. The changed APC object passes that profile, and the complete driver passes the project's medium Clang profile with-Werror.General C checklist
APCC_MIB_VERSIONwas bumped.ambient.temperaturevariable.NEWS.adocwas updated.AI assistance
OpenAI Codex
gpt-5.6-solwas used for planning, repository analysis, implementation, review, drafting and validation, including controller and delegated work. The human contributor reviewed the change and remains responsible for it.