You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I identified and validated the root cause: PR #3607 defines Socket::setSSLContext() and getSSLContext() unconditionally, although _ssl_ctx and SSL_CTX exist only with OpenSSL. NSS builds consequently fail at compilation.
A focused fix—guarding those OpenSSL-specific accesses and initializing the new NSS state—successfully builds the exact failing configuration (clang, NSS, libusb-0.1) in a temporary checkout of the failing PR.
However, the checked-out working branch is based on master and does not contain the failing setSSLContext changes from PR #3607, so no surgical repository change can be committed here without importing that unrelated 25-file PR. Please provide a checkout based on PR #3607 (or authorize updating that branch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General points
NSS builds failed because OpenSSL-only
SSL_CTXstorage was accessed unconditionally by the new C++ context API.Frequent "underwater rocks" for driver addition/update PRs
DRIVER_VERSIONmacro or its equivalent.scripts/upower/95-upower-hid.hwdb.docs/nut-names.txt.data/driver.list.inif applicable.Frequent "underwater rocks" for general C code PRs
Makefile.amrecipes and passedmake distcheck.General documentation updates
NEWS.adoc, possibly alsoUPGRADING.adoc.docs/acknowledgements.txt.make spellcheckand updateddocs/nut.dictif needed.Additional work may be needed after posting this PR