feat: new registration API#490
Open
holyspectral wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
This is ready for review, but package path in go.mod has to be changed once neuvector side is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Today, the scanner registration is done via
ScannerRegisterStreamandScannerRegisterAPI. The problem of these two APIs is that, scanner has to extract and send the whole cvedb to controller, and these data will be kept in controller memory until they're handled, even the cvedb is already up-to-date.The cvedb's raw size has grown from 211.5mb (3.800) to 340.3 MB (4.196) in one year, so this becomes a huge memory pressure when scanner sends the cvedb to the same controller about the same time. If there is a memory limit like 2G in place, when all register requests are sent to the same controller, the controller can be killed immediately by OOM killer.
This PR implements a new gRPC API,
ScannerRegisterV3for scanner to send cvedb metadata first in order to register. If the cvedb is newer, controller will ask the scanner to send the whole cvedb.Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement