feat(auto-upload): ignore battery optimization with sync now - #17396
feat(auto-upload): ignore battery optimization with sync now#17396alperozturk96 wants to merge 7 commits into
Conversation
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17396-IT-master-08-57 |
|
Can this button be accessed also without putting phone in power save mode? |
No and this button only re-trigger auto upload via bypassing the battery optimization. It does not ignore every check and try to force upload every file. |
9b404be to
c6a973b
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/31572128059/artifacts/9131895982 |
It says 404 when visiting mobile browser, even when I request desktop site. |
c6a973b to
52581fa
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/32000183161/artifacts/9278348478 |
52581fa to
3f391f5
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/32222236432/artifacts/9354451949 |
|
Hi @alperozturk96 , I noticed the banner doesn't fit nicely on small screens: |
|
Tested it and it works (when I press "Sync now" it synces correctly), but I noticed the sync remains unrestricted for a while (I've seen with the debugger, in ContentObserverWork:79, a call to checkAndTriggerAutoUpload where overridePowerSaving was still true). How to repro:
Should you need some help in reproducing, just let me know! |
3f391f5 to
1912c1c
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/32260099087/artifacts/9368106934 |
Fixed via: 5792b51 
|
|
APK file: https://github.com/nextcloud/android/actions/runs/32261113774/artifacts/9368853506 |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # app/src/main/java/com/nextcloud/ui/component/UploadWarningCard.kt
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
5792b51 to
a76a05d
Compare
|
APK file: https://github.com/nextcloud/android/actions/runs/32365959689/artifacts/9405461598 |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
|
@daniele-verducci @tobiasKaminsky User may press the sync now back to back and this can trigger worker multiple times. Thus I think better to have 5 minutes debounce. What do you think? Screen_recording_20260820_141928.webm |
|
Makes sense to me |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://github.com/nextcloud/android/actions/runs/32368304545/artifacts/9406869650 |
5 min debounce sounds very "random". So probably best to check if the job is still running and only then allow to restart it? |
4 participants
Implements:
App's shows a banner if device is in power save mode and this affects the auto upload behaviour such as delays.
This PR adds "Sync now" button inside the banner to re-trigger auto upload via bypassing the battery optimization.
#7019