Skip to content

fix(Notifier): Correct wording #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelklehr merged 1 commit into from
Jun 23, 2026
+6 −6
Merged

fix(Notifier): Correct wording #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/Notification/Notifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ public function prepare(INotification $notification, string $languageCode): INot
return $notification;

case 'assignment_approval_pending':
$subject = $l->t('Assignment run pending review');
$subject = $l->t('Scheduled task is pending review');

$iconUrl = $this->url->getAbsoluteURL($this->url->imagePath(Application::APP_ID, 'app-dark.svg'));

Expand All @@ -353,7 +353,7 @@ public function prepare(INotification $notification, string $languageCode): INot
->setLink($this->url->linkToRouteAbsolute(Application::APP_ID . '.assistant.getAssistantStandalonePage', ['sessionId' => $params['sessionId']]))
->setIcon($iconUrl);

$actionLabel = $l->t('View assignment');
$actionLabel = $l->t('View scheduled task');
$action = $notification->createAction();
$action->setLabel($actionLabel)
->setParsedLabel($actionLabel)
Expand All @@ -365,7 +365,7 @@ public function prepare(INotification $notification, string $languageCode): INot
return $notification;

case 'assignment_successful':
$subject = $l->t('Assignment succeeded');
$subject = $l->t('Scheduled task succeeded');

$iconUrl = $this->url->getAbsoluteURL($this->url->imagePath(Application::APP_ID, 'app-dark.svg'));

Expand All @@ -378,7 +378,7 @@ public function prepare(INotification $notification, string $languageCode): INot
->setLink($this->url->linkToRouteAbsolute(Application::APP_ID . '.assistant.getAssistantStandalonePage', ['sessionId' => $params['sessionId']]))
->setIcon($iconUrl);

$actionLabel = $l->t('View assignment result');
$actionLabel = $l->t('View result');
$action = $notification->createAction();
$action->setLabel($actionLabel)
->setParsedLabel($actionLabel)
Expand All @@ -390,7 +390,7 @@ public function prepare(INotification $notification, string $languageCode): INot
return $notification;

case 'assignment_failure':
$subject = $l->t('Assignment failed');
$subject = $l->t('Scheduled task failed');

$iconUrl = $this->url->getAbsoluteURL($this->url->imagePath(Application::APP_ID, 'app-dark.svg'));

Expand All @@ -403,7 +403,7 @@ public function prepare(INotification $notification, string $languageCode): INot
->setLink($this->url->linkToRouteAbsolute(Application::APP_ID . '.assistant.getAssistantStandalonePage', ['sessionId' => $params['sessionId']]))
->setIcon($iconUrl);

$actionLabel = $l->t('View assignment result');
$actionLabel = $l->t('View result');
$action = $notification->createAction();
$action->setLabel($actionLabel)
->setParsedLabel($actionLabel)
Expand Down
Loading