test(admin-controller): add unit tests covering all controller endpoints#2544
Open
cristianscheid wants to merge 1 commit into
Open
test(admin-controller): add unit tests covering all controller endpoints#2544cristianscheid wants to merge 1 commit into
cristianscheid wants to merge 1 commit into
Conversation
cristianscheid
force-pushed
the
test/noid/admin-controller
branch
from
15e993a to
1f8ae82
Compare
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
test/noid/admin-controller
branch
from
1f8ae82 to
e3a72bc
Compare
come-nc
reviewed
Jun 23, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
I think it’s the right kind of tests.
You could use assertSame directly on the array instead of each key/value I think.
| /** @var CircleService|MockObject */ | ||
| private $circleService; | ||
| foreach ([self::TEST_USER_1, self::TEST_USER_2] as $userId) { | ||
| $user = $c->get(IUserManager::class)->get($userId); |
Contributor
There was a problem hiding this comment.
You should get the user manager only once and store it in a var
| } | ||
|
|
||
| public function testDestroy(): void { | ||
| $c = $this->container; |
Contributor
There was a problem hiding this comment.
Suggested change
| $c = $this->container; | |
| $circleService = $this->container->get(CircleService::class); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
testCirclesList()and add coverage for all remaining endpoints inlib/Controller/AdminController.Checklist
3. to review, feature component)stable32)AI (if applicable)