fix(OpenAiAPIService): Throw UserFacingProcessingException if service is not responding properly#380
Merged
Merged
Conversation
… is not responding properly Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/user-facing-error-500
branch
from
3724466 to
7bef1b3
Compare
julien-nc
requested changes
Jun 16, 2026
Member
There was a problem hiding this comment.
The UserFacingProcessingException is caught in the providers and RuntimeException is thrown instead. Check the catch block at the end of TextToTextProvider for example. We should probably make a special case and let UserFacingProcessingException propagate to the upper level.
Naive fix:
} catch (Exception $e) {
if ($e instanceof UserFacingProcessingException) {
throw $e;
}
throw new RuntimeException('OpenAI/LocalAI request failed: ' . $e->getMessage());
}
Contributor
|
or maybe } catch (UserFacingProcessingException $e) {
throw $e;
} catch (Exception $e) {
throw new RuntimeException('OpenAI/LocalAI request failed: ' . $e->getMessage());
} |
kyteinsky
reviewed
Jun 16, 2026
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Member
Author
|
I'm not bothering to fix psalm. Julien's PR does that already. |
julien-nc
approved these changes
Jun 16, 2026
kyteinsky
reviewed
Jun 16, 2026
Comment on lines
-122
to
+123
| throw new RuntimeException('Too many files given. Max is 500'); | ||
| throw new ProcessingException('Too many files given. Max is 500'); |
Contributor
There was a problem hiding this comment.
maybe qualifies for UserFacingProcessingException
Member
Author
There was a problem hiding this comment.
Can be a different PR, let's try to not bloat up this one too much
Comment on lines
-132
to
+133
| throw new RuntimeException('Filesize of input files too large. Max is 50MB'); | ||
| throw new ProcessingException('Filesize of input files too large. Max is 50MB'); |
Comment on lines
-137
to
+138
| throw new RuntimeException('Invalid input file type ' . $fileType); | ||
| throw new ProcessingException('Invalid input file type ' . $fileType); |
Contributor
There was a problem hiding this comment.
not too sure about this one, but could be harmless if the user sees it anyway
Comment on lines
-147
to
+148
| throw new RuntimeException('Invalid input file type for OpenAI ' . $fileType); | ||
| throw new ProcessingException('Invalid input file type for OpenAI ' . $fileType); |
Contributor
There was a problem hiding this comment.
this too perhaps if the above is done
marcelklehr
commented
Jun 16, 2026
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
commented
Jun 16, 2026
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)