fix: Rewind iterator before calling current/next - #2218
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Antreesy
reviewed
Sep 1, 2026
| @@ -71,6 +71,7 @@ public function get($query = '', $count = 50, $offset = 0): JSONResponse { | |||
| */ | |||
| private function getLastItem() { | |||
| $iterator = $this->logIteratorFactory->getLogIterator($this->settingsService->getShownLevels()); | |||
Collaborator
There was a problem hiding this comment.
This already does rewind on creating from class, and calling next() once - so it should be on the latest line already:
$this->logIteratorFactory->getLogIterator($this->settingsService->getShownLevels());
...
new LogIterator($handle, $dateFormat, $timezone);
...
__construct($handle, string $dateFormat, string $timezone) {
...
$this->rewind();
...
$this->next();What does it fix? I remember investigating something with it, but didn't finish. But not sure that current code brings something to it
Member
Author
There was a problem hiding this comment.
Before the fix I always got null has return from getLastItem
Contributor
There was a problem hiding this comment.
There is something weird going on because I agree with @Antreesy the code is supposed to return a rewinded iterator already from the factory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃 AI (if applicable)