Skip to content

fix(provisioning): prevent silent save failure around master user#13076

Open
tnxfi wants to merge 1 commit into
nextcloud:local-add-masteruserfrom
tnxfi:fix/masteruser-save-feedback
Open

fix(provisioning): prevent silent save failure around master user#13076
tnxfi wants to merge 1 commit into
nextcloud:local-add-masteruserfrom
tnxfi:fix/masteruser-save-feedback

Conversation

@tnxfi

@tnxfi tnxfi commented Jun 12, 2026

Copy link
Copy Markdown

For #12442

With a master user set, saving the provisioning config could fail with no visible feedback when "use master password" was toggled off, or when the separator was left empty (the separator became required-but-empty, so the submit was blocked by native validation only).

  • Clear master user + separator when master password is disabled, so a value that just became hidden cannot block validation or silently survive.
  • Default the master user separator to "*" (Dovecot default) when a master user is entered, so the separator field is never required-but-empty.
  • Give the master password input a unique id per provisioning config (it was a hardcoded duplicate shared with the "add new config" form).

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

With a master user set, saving the provisioning config could fail with no
visible feedback when "use master password" was toggled off, or when the
separator was left empty (the separator became required-but-empty, so the
submit was blocked by native validation only).

- Clear master user + separator when master password is disabled, so a value
  that just became hidden cannot block validation or silently survive.
- Default the master user separator to "*" (Dovecot default) when a master
  user is entered, so the separator field is never required-but-empty.
- Give the master password input a unique id per provisioning config (it was a
  hardcoded duplicate shared with the "add new config" form).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChristophWurst

Copy link
Copy Markdown
Member

Thanks for the PR

@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants