Skip to content

fix: make string plural-compatible for non-English langs + add translator hints #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emberfiend wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make string plural-compatible for non-English langs + add translator hints #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/views/OfficeOverview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,13 @@

<section v-else-if="activeCreator" class="office-overview__files" aria-labelledby="files-section-heading">
<div role="status" class="sr-only">
{{ t('office', '{count} found in {category}', { count: files.length, category: activeCategoryName }) }}
<!-- TRANSLATORS: number of Documents/Spreadsheets/Presentations/Diagrams found -->
{{ n('office', '{count} found in {category}', '{count} found in {category}', files.length, { count: files.length, category: activeCategoryName }) }}

Check failure on line 255 in src/views/OfficeOverview.vue

View workflow job for this annotation

GitHub Actions / NPM test

Unhandled error 

TypeError: _ctx.n is not a function
 ❯ src/views/OfficeOverview.vue:255:11
 ❯ Proxy.renderFnWithContext node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:699:13
 ❯ Proxy.<anonymous> node_modules/@vue/test-utils/dist/vue-test-utils.cjs.js:7823:63
 ❯ renderComponentRoot node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4543:16
 ❯ ReactiveEffect.componentUpdateFn [as fn] node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:6148:26
 ❯ ReactiveEffect.run node_modules/@vue/reactivity/dist/reactivity.cjs.js:264:19
 ❯ ReactiveEffect.runIfDirty node_modules/@vue/reactivity/dist/reactivity.cjs.js:302:12
 ❯ callWithErrorHandling node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:200:33
 ❯ flushJobs node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:405:9

This error originated in "src/views/OfficeOverview.spec.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
The latest test that might've caused the error is "shows "No {category} found" with a switch-to-All hint when the mine filter has no matches". It might mean one of the following:
- The error was thrown, while Vitest was running this test.
- If the error occurred after the test had been completed, this was the last documented test before it was thrown.
</div>

<div class="office-overview__files-header">
<h2 id="files-section-heading" class="office-overview__files-title">
<!-- TRANSLATORS: category is Documents/Spreadsheets/Presentations/Diagrams -->
{{ t('office', 'Recent {category}', { category: activeCategoryName }) }}
</h2>
</div>
Expand Down
Loading