Skip to content

debug: add logging when hook node has null path #61551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
icewind1991 wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −6
Draft

debug: add logging when hook node has null path #61551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions lib/private/Files/Node/HookConnector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,15 +214,36 @@ private function getNodeForPath(string $path, bool $isDir = false): Node {
$info = null;
}
if ($isDir || Filesystem::is_dir($path)) {
return new NonExistingFolder($this->root, $this->view, $fullPath, $info);
$node = new NonExistingFolder($this->root, $this->view, $fullPath, $info);
} else {
return new NonExistingFile($this->root, $this->view, $fullPath, $info);
$node = new NonExistingFile($this->root, $this->view, $fullPath, $info);
}
}
if ($info->getType() === FileInfo::TYPE_FILE) {
return new File($this->root, $this->view, $info->getPath(), $info);
} else {
return new Folder($this->root, $this->view, $info->getPath(), $info);
if ($info->getType() === FileInfo::TYPE_FILE) {
$node = new File($this->root, $this->view, $info->getPath(), $info);
} else {
$node = new Folder($this->root, $this->view, $info->getPath(), $info);
}
}
if ($node->getPath() === null) {
$e = new \Exception("null path when trying to get node for hook");
$data = [
'exception' => $e,
'original_path' => $path,
'view_root' => Filesystem::getView()->getRoot(),
];
if ($info) {
$data = $data + [
'mount_point' => $info->getMountPoint()->getMountPoint(),
'mount_provider_class' => $info->getMountPoint()->getMountProvider(),
'storage' => $info->getStorage()->getId(),
'file_id' => $info->getId(),
];
} else {
$data['info'] = 'not-found';
}
$this->logger->error($e->getMessage(), $data);
}
return $node;
}
}
Loading