Skip to content

test: Stop using the internal real database #61566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
provokateurin wants to merge 2 commits into
base: master
Choose a base branch
from
+57 −34
Draft

test: Stop using the internal real database #61566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c7eee
test: Stop using the internal real database
provokateurin Jun 11, 2026
d27df61
fix(TestCase): Make $realDatabase private
provokateurin Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 26 additions & 22 deletions apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,33 @@

use OCA\DAV\CalDAV\Reminder\Backend as ReminderBackend;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\IDBConnection;
use OCP\Server;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\MockObject\MockObject;
use Test\TestCase;

#[Group('DB')]
class BackendTest extends TestCase {
private ReminderBackend $reminderBackend;
private ITimeFactory&MockObject $timeFactory;

protected function setUp(): void {
parent::setUp();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->delete('calendar_reminders')->executeStatement();
$query->delete('calendarobjects')->executeStatement();
$query->delete('calendars')->executeStatement();

$this->timeFactory = $this->createMock(ITimeFactory::class);
$this->reminderBackend = new ReminderBackend(self::$realDatabase, $this->timeFactory);
$this->reminderBackend = new ReminderBackend(Server::get(IDBConnection::class), $this->timeFactory);

$this->createRemindersTestSet();
}

protected function tearDown(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->delete('calendar_reminders')->executeStatement();
$query->delete('calendarobjects')->executeStatement();
$query->delete('calendars')->executeStatement();
Expand All @@ -42,7 +46,7 @@ protected function tearDown(): void {
}

public function testCleanRemindersForEvent(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -52,7 +56,7 @@ public function testCleanRemindersForEvent(): void {

$this->reminderBackend->cleanRemindersForEvent(1);

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -62,7 +66,7 @@ public function testCleanRemindersForEvent(): void {
}

public function testCleanRemindersForCalendar(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -72,7 +76,7 @@ public function testCleanRemindersForCalendar(): void {

$this->reminderBackend->cleanRemindersForCalendar(1);

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -82,7 +86,7 @@ public function testCleanRemindersForCalendar(): void {
}

public function testRemoveReminder(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -92,7 +96,7 @@ public function testRemoveReminder(): void {

$this->reminderBackend->removeReminder((int)$rows[3]['id']);

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand Down Expand Up @@ -189,7 +193,7 @@ public function testGetAllScheduledRemindersForEvent(): void {
}

public function testInsertReminder(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -200,7 +204,7 @@ public function testInsertReminder(): void {
$this->reminderBackend->insertReminder(42, 1337, 'uid99', true, 12345678,
true, 'hash99', 'hash42', 'AUDIO', false, 12345670, false);

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -227,7 +231,7 @@ public function testInsertReminder(): void {
}

public function testUpdateReminder(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$rows = $query->select('*')
->from('calendar_reminders')
->executeQuery()
Expand All @@ -242,7 +246,7 @@ public function testUpdateReminder(): void {

$this->reminderBackend->updateReminder($reminderId, $newNotificationDate);

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$row = $query->select('notification_date')
->from('calendar_reminders')
->where($query->expr()->eq('id', $query->createNamedParameter($reminderId)))
Expand All @@ -253,7 +257,7 @@ public function testUpdateReminder(): void {
}

private function createRemindersTestSet(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendars')
->values([
'id' => $query->createNamedParameter(1),
Expand All @@ -262,7 +266,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendars')
->values([
'id' => $query->createNamedParameter(99),
Expand All @@ -271,7 +275,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendarobjects')
->values([
'id' => $query->createNamedParameter(1),
Expand All @@ -281,7 +285,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendarobjects')
->values([
'id' => $query->createNamedParameter(2),
Expand All @@ -291,7 +295,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendarobjects')
->values([
'id' => $query->createNamedParameter(10),
Expand All @@ -301,7 +305,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendar_reminders')
->values([
'calendar_id' => $query->createNamedParameter(1),
Expand All @@ -319,7 +323,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendar_reminders')
->values([
'calendar_id' => $query->createNamedParameter(1),
Expand All @@ -337,7 +341,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendar_reminders')
->values([
'calendar_id' => $query->createNamedParameter(1),
Expand All @@ -355,7 +359,7 @@ private function createRemindersTestSet(): void {
])
->executeStatement();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendar_reminders')
->values([
'calendar_id' => $query->createNamedParameter(99),
Expand Down
7 changes: 5 additions & 2 deletions apps/dav/tests/unit/CalDAV/ResourceBooking/AbstractPrincipalBackendTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,12 @@
use OCA\DAV\CalDAV\Proxy\ProxyMapper;
use OCA\DAV\CalDAV\ResourceBooking\ResourcePrincipalBackend;
use OCA\DAV\CalDAV\ResourceBooking\RoomPrincipalBackend;
use OCP\IDBConnection;
use OCP\IGroupManager;
use OCP\IUser;
use OCP\IUserSession;
use OCP\Server;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\LoggerInterface;
use Sabre\DAV\PropPatch;
Expand Down Expand Up @@ -42,7 +45,7 @@ protected function setUp(): void {
}

protected function tearDown(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();

$query->delete('calendar_resources')->executeStatement();
$query->delete('calendar_resources_md')->executeStatement();
Expand Down Expand Up @@ -454,7 +457,7 @@ public function testFindByUriByUnknownUri(): void {
}

protected function createTestDatasetInDb() {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert($this->mainDbTable)
->values([
'backend_id' => $query->createNamedParameter('backend1'),
Expand Down
6 changes: 5 additions & 1 deletion apps/dav/tests/unit/CalDAV/ResourceBooking/ResourcePrincipalBackendTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@
namespace OCA\DAV\Tests\unit\CalDAV\ResourceBooking;

use OCA\DAV\CalDAV\ResourceBooking\ResourcePrincipalBackend;
use OCP\IDBConnection;
use OCP\Server;
use PHPUnit\Framework\Attributes\Group;

#[Group('DB')]
class ResourcePrincipalBackendTest extends AbstractPrincipalBackendTestCase {
protected function setUp(): void {
parent::setUp();

$this->principalBackend = new ResourcePrincipalBackend(self::$realDatabase,
$this->principalBackend = new ResourcePrincipalBackend(Server::get(IDBConnection::class),
$this->userSession, $this->groupManager, $this->logger, $this->proxyMapper);

$this->mainDbTable = 'calendar_resources';
Expand Down
6 changes: 5 additions & 1 deletion apps/dav/tests/unit/CalDAV/ResourceBooking/RoomPrincipalBackendTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@
namespace OCA\DAV\Tests\unit\CalDAV\ResourceBooking;

use OCA\DAV\CalDAV\ResourceBooking\RoomPrincipalBackend;
use OCP\IDBConnection;
use OCP\Server;
use PHPUnit\Framework\Attributes\Group;

#[Group('DB')]
class RoomPrincipalBackendTest extends AbstractPrincipalBackendTestCase {
protected function setUp(): void {
parent::setUp();

$this->principalBackend = new RoomPrincipalBackend(self::$realDatabase,
$this->principalBackend = new RoomPrincipalBackend(Server::get(IDBConnection::class),
$this->userSession, $this->groupManager, $this->logger, $this->proxyMapper);

$this->mainDbTable = 'calendar_rooms';
Expand Down
8 changes: 6 additions & 2 deletions apps/user_status/tests/Unit/Db/UserStatusMapperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,23 @@
use OCA\UserStatus\Db\UserStatusMapper;
use OCP\AppFramework\Db\DoesNotExistException;
use OCP\DB\Exception;
use OCP\IDBConnection;
use OCP\Server;
use PHPUnit\Framework\Attributes\Group;
use Test\TestCase;

#[Group('DB')]
class UserStatusMapperTest extends TestCase {
private UserStatusMapper $mapper;

protected function setUp(): void {
parent::setUp();

// make sure that DB is empty
$qb = self::$realDatabase->getQueryBuilder();
$qb = Server::get(IDBConnection::class)->getQueryBuilder();
$qb->delete('user_status')->executeStatement();

$this->mapper = new UserStatusMapper(self::$realDatabase);
$this->mapper = new UserStatusMapper(Server::get(IDBConnection::class));
}

public function testGetTableName(): void {
Expand Down
14 changes: 9 additions & 5 deletions tests/lib/Calendar/ResourcesRoomsUpdaterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,17 @@
use OCP\Calendar\Resource\IManager as IResourceManager;
use OCP\Calendar\Resource\IResource;
use OCP\Calendar\Room\IManager as IRoomManager;
use OCP\IDBConnection;
use OCP\Server;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Container\ContainerInterface;
use Test\TestCase;

interface tmpI extends IResource, IMetadataProvider {
}

#[Group('DB')]
class ResourcesRoomsUpdaterTest extends TestCase {
private ResourcesRoomsUpdater $updater;

Expand Down Expand Up @@ -56,14 +60,14 @@ protected function setUp(): void {

$this->updater = new ResourcesRoomsUpdater(
$this->container,
self::$realDatabase,
Server::get(IDBConnection::class),
$this->calDavBackend
);
}

#[\Override]
protected function tearDown(): void {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->delete('calendar_resources')->executeStatement();
$query->delete('calendar_resources_md')->executeStatement();
$query->delete('calendar_rooms')->executeStatement();
Expand Down Expand Up @@ -209,7 +213,7 @@ public function testUpdateBoth(): void {
$this->updater->updateResources();
$this->updater->updateRooms();

$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->select('*')->from('calendar_resources');

$rows = [];
Expand Down Expand Up @@ -280,7 +284,7 @@ public function testUpdateBoth(): void {
],
], $rows);

$query2 = self::$realDatabase->getQueryBuilder();
$query2 = Server::get(IDBConnection::class)->getQueryBuilder();
$query2->select('*')->from('calendar_resources_md');

$rows2 = [];
Expand Down Expand Up @@ -335,7 +339,7 @@ public function testUpdateBoth(): void {
}

protected function createTestResourcesInCache() {
$query = self::$realDatabase->getQueryBuilder();
$query = Server::get(IDBConnection::class)->getQueryBuilder();
$query->insert('calendar_resources')
->values([
'backend_id' => $query->createNamedParameter('backend1'),
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/TestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ abstract class TestCase extends \PHPUnit\Framework\TestCase {
private QueueBus $commandBus;

/** @psalm-suppress ImpureStaticProperty For tests it's not an issue */
protected static ?IDBConnection $realDatabase = null;
private static ?IDBConnection $realDatabase = null;
/** @psalm-suppress ImpureStaticProperty */
private static bool $wasDatabaseAllowed = false;
protected array $services = [];
Expand Down
Loading