test(db): cover migration version sorting - #63536
Open
joshtrichards wants to merge 4 commits into
Open
Conversation
joshtrichards
requested review from
icewind1991,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
August 24, 2026 13:15
joshtrichards
added
2. developing
Signed-off-by: Josh <josh.t.richards@gmail.com>
A follow-up to #47515 that exercises getMigratedVersions() for regressions for real, since the existing tests mock it and don't test it. Assisted-by: Copilot:gpt-5.6-sol Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/test-fix-db-migration-version-handling
branch
from
August 24, 2026 15:39
edcf452 to
c4629f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The timestamp-only values in today’s tests are remnants from the initial test scaffolding from PR #5231. The formatting in the production code was changed before being merged to consist of version+timestamp, but tests still had the old approach.
Main issue is that only the defensive fallback in
MigrationService::sortMigrations()rather than the production sort path.Changes:
<version>Date<timestamp> identifiers.getMigratedVersions())Historical context: #5231 and #47515.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)