fix(db): reject invalid and duplicate migration identifiers - #63539
Open
joshtrichards wants to merge 5 commits into
Open
fix(db): reject invalid and duplicate migration identifiers#63539joshtrichards wants to merge 5 commits into
joshtrichards wants to merge 5 commits into
Conversation
CarlSchwan
approved these changes
Aug 24, 2026
Validate migration names against the supported version and timestamp format. Reject overlapping identifiers discovered in multiple migration files instead of silently overwriting one of them. This hardens migrations by preventing them from running in a non-deterministic order when an unsupported migration identifier mix might produce a plausible but incorrect migration order. Assisted-by: GitHubCopilot:gpt-5.6-sol Signed-off-by: Josh <josh.t.richards@gmail.com>
Assisted-by: Copilot:gpt-5.6-sol Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
For sortMigrations() Assisted-by: Copilot:gpt-5.6-sol Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/fix-db-migration-versioning-hardening
branch
from
August 24, 2026 15:39
7bb7445 to
a8f1397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens migrations by preventing invalid or duplicate migration identifiers from producing an incorrect or ambiguous migration order.
Specifically:
<version>Date<YYYYMMDDHHMMSS>identifier format.Changes:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)