Skip to content

fix(core): don't hijack Ctrl+F in editors or behind modals - #63541

Open
pringelmann wants to merge 2 commits into
masterfrom
fix/63409/unified-search-hotkey-guards
Open

fix(core): don't hijack Ctrl+F in editors or behind modals#63541
pringelmann wants to merge 2 commits into
masterfrom
fix/63409/unified-search-hotkey-guards

Conversation

@pringelmann

@pringelmann pringelmann commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Unified search bound its own keydown listener that never checked the event target or open modals, so Ctrl+F inside a Text document opened search instead of the browser's find bar. useHotKey already guards both, so this uses it instead of duplicating that logic in core.

Behaviour changes

  • Ctrl+F in an editor or input now goes to the browser. Same behind an open modal.
  • Ctrl+K works again on /settings/users, /settings/apps and /apps/deck. It was checking the Ctrl+F opt-out, which nothing on that list uses for Ctrl+K, so Firefox took the key. Pre-existing bug.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes (no visual change)
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (tests, reviewed by me)

@pringelmann
pringelmann requested a review from a team as a code owner August 24, 2026 14:41
@pringelmann
pringelmann requested review from kristian-zendato, skjnldsv and sorbaugh and removed request for a team August 24, 2026 14:41
@pringelmann pringelmann self-assigned this Aug 24, 2026
@pringelmann
pringelmann requested a review from susnux August 24, 2026 14:41
@pringelmann pringelmann added this to the Nextcloud 35 milestone Aug 24, 2026
@pringelmann

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@pringelmann

Copy link
Copy Markdown
Contributor Author

/compile rebase

pringelmann and others added 2 commits August 24, 2026 16:34
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-command force-pushed the fix/63409/unified-search-hotkey-guards branch from f63b5dc to 817fd75 Compare August 24, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search for word inside page is impossible

3 participants