Skip to content

Fix: Large table causes sql error #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koc wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: Large table causes sql error #2242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80656a6
Fix: Large table causes sql error
Koc Dec 28, 2025
0d16156
Fix: Large table causes sql error (cache cells)
Koc Dec 29, 2025
e804e3c
Fix: Large table causes sql error (code review fixes WIP)
Koc Jun 20, 2026
a150684
Fix: Large table causes sql error (code review fixes WIP)
Koc Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Share your tables and views with users and groups within your cloud.
Have a good time and manage whatever you want.

]]></description>
<version>2.2.0</version>
<version>2.3.0</version>

@blizzz blizzz Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>2.3.0</version>
<version>2.3.0-dev.0</version>

Would go for a pre-release number, unless we'd immediately release afterwards.

<licence>AGPL-3.0-or-later</licence>
<author>Nextcloud GmbH and Nextcloud contributors</author>
<namespace>Tables</namespace>
Expand Down Expand Up @@ -58,6 +58,7 @@ Have a good time and manage whatever you want.
<post-migration>
<step>OCA\Tables\Migration\NewDbStructureRepairStep</step>
<step>OCA\Tables\Migration\DbRowSleeveSequence</step>
<step>OCA\Tables\Migration\CacheSleeveCells</step>
</post-migration>
</repair-steps>
<commands>
Expand Down
4 changes: 2 additions & 2 deletions lib/Db/ColumnMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function findAll(array $id): array {

/**
* @param integer $tableId
* @return array
* @return Column[]
* @throws Exception
*/
public function findAllByTable(int $tableId): array {
Expand All @@ -116,7 +116,7 @@ public function findAllByTable(int $tableId): array {

/**
* @param integer $tableID
* @return array
* @return int[]
* @throws Exception
*/
public function findAllIdsByTable(int $tableID): array {
Expand Down
Loading
Loading