Skip to content

feat: add notifications#2681

Open
luka-nextcloud wants to merge 1 commit into
mainfrom
add-notifications
Open

feat: add notifications#2681
luka-nextcloud wants to merge 1 commit into
mainfrom
add-notifications

Conversation

@luka-nextcloud

@luka-nextcloud luka-nextcloud commented May 22, 2026

Copy link
Copy Markdown
Contributor

Resolves: #1460

Demo:
demo.webm

@luka-nextcloud luka-nextcloud force-pushed the add-notifications branch 2 times, most recently from 57335c5 to bd02b34 Compare June 4, 2026 14:28
@luka-nextcloud luka-nextcloud marked this pull request as ready for review June 4, 2026 14:28

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luka-nextcloud! I did only little smoke testing, but that was already working. I left some comments around here in the code, the ones marked with 💡 are not blocking, but for consideration.

What I also did not check yet, question back for you, do you think this scales with a bigger number of users, or users in a group?

My impression is that in some places there is code that is quite similar, an almost-duplication. There might be potential to reduce this, but do not consider this critical.

Comment thread src/modules/modals/sections/NotificationsSettings.vue Outdated
Comment thread src/modules/modals/sections/NotificationsSettings.vue Outdated
Comment thread src/modules/modals/sections/NotificationsSettings.vue Outdated
Comment thread lib/Activity/ActivityManager.php
Comment thread lib/Activity/ActivityManager.php Outdated
Comment thread lib/Notification/NotificationHelper.php Outdated
Comment thread lib/Notification/NotificationHelper.php Outdated
Comment thread lib/Notification/NotificationHelper.php Outdated
Comment thread lib/Service/ConfigService.php Outdated
Comment thread src/modules/modals/sections/NotificationsSettings.vue Outdated
@blizzz

blizzz commented Jun 12, 2026

Copy link
Copy Markdown
Member

P.S.: what I forgot to missed to add: 💄 better to not include the row ID in the text of the notification, it does not really help people and looks technical. Just link row, there is a direct link already anyway (at least for the creates and updates).

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if should be done in another PR, but could we have notifications for asynchronous import? Right now, users never know exactly when import is done and it would be great

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

Comment thread lib/Notification/NotificationHelper.php Outdated
Comment thread src/shared/components/ActivityList.vue Outdated
Comment thread lib/Notification/NotificationHelper.php
Comment thread lib/Notification/Notifier.php Outdated
Comment thread lib/Notification/NotificationHelper.php
Comment thread lib/Activity/Filter.php Outdated
@luka-nextcloud

luka-nextcloud commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

not sure if should be done in another PR, but could we have notifications for asynchronous import? Right now, users never know exactly when import is done and it would be great

I think the asynchronous import notification should be another PR since this PR is already big enough.
I've created a followup task here - #2764

@luka-nextcloud luka-nextcloud requested review from blizzz and enjeck June 24, 2026 13:15
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notifications

3 participants