Skip to content

Compare literal Markdown off the main thread - #9050

Merged
hweihwang merged 1 commit into
review/structured-markdown-comparison-documentsfrom
review/structured-markdown-source-comparison
Sep 3, 2026
Merged

Compare literal Markdown off the main thread#9050
hweihwang merged 1 commit into
review/structured-markdown-comparison-documentsfrom
review/structured-markdown-source-comparison

Conversation

@hweihwang

@hweihwang hweihwang commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Part 4 of the version-comparison work for nextcloud/collectives#599: a literal Markdown source comparison, for what a rendered view cannot show.

  • Source view with line numbers and token-level emphasis; diagnostics for line-ending changes, per-line LF/CRLF badges, trailing whitespace, missing final newlines
  • All computation in a cancellable module worker with three explicit limits (2,000,000 characters, 50,000 edits, 2,000 ms). A limit always reports itself as limited, never as "identical"

Depends on: #9049 (base review/structured-markdown-comparison-documents). Last Text unit; then nextcloud/collectives#2699 and #2700.

Full story, screenshots and the test matrix live in the #599 implementation update: nextcloud/collectives#599 (comment)

AI disclosure: developed with OpenAI Codex (gpt-5.6-sol). Codex generated the implementation and tests under my direction; I reviewed, cleaned and verified the code, ran the full test and CI matrix, and signed the commits personally.

Assisted-by: OpenAI Codex:gpt-5.6-sol
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang
hweihwang force-pushed the review/structured-markdown-source-comparison branch from 00bfeab to b5ff1b0 Compare September 1, 2026 21:09
@hweihwang
hweihwang marked this pull request as ready for review September 1, 2026 21:24
@hweihwang
hweihwang requested review from benjaminfrueh and removed request for max-nextcloud, mejo- and silverkszlo September 1, 2026 21:34
@benjaminfrueh

Copy link
Copy Markdown
Contributor

/backport to stable35

@hweihwang
hweihwang merged commit 20dcd03 into main Sep 3, 2026
71 checks passed
@hweihwang
hweihwang deleted the review/structured-markdown-source-comparison branch September 3, 2026 09:17
@backportbot

backportbot Bot commented Sep 3, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/9050/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b5ff1b0c

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9050/stable35

Error: Failed to check for changes with origin/stable35: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants