Fix sign job failure in container publish workflow by handling multiline tag outputs safely - #1198
Merged
Merged
Conversation
Co-authored-by: hyphaltip <48827+hyphaltip@users.noreply.github.com>
Co-authored-by: hyphaltip <48827+hyphaltip@users.noreply.github.com>
Co-authored-by: hyphaltip <48827+hyphaltip@users.noreply.github.com>
Co-authored-by: hyphaltip <48827+hyphaltip@users.noreply.github.com>
Co-authored-by: hyphaltip <48827+hyphaltip@users.noreply.github.com>
Co-authored-by: hyphaltip <48827+hyphaltip@users.noreply.github.com>
Co-authored-by: hyphaltip <48827+hyphaltip@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job sign
Fix Aug 11, 2026
sign job failure in container publish workflow by handling multiline tag outputs safely
hyphaltip
marked this pull request as ready for review
August 11, 2026 05:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Build and Sign Container Imageworkflow was failing in thesignjob because${{ needs.build.outputs.tags }}is multiline and was expanded directly in a shellforloop, producing invalid bash syntax. This PR updates tag consumption and related signing/provenance logic to be robust for multi-tag releases.Root cause addressed
for tag in ${{ needs.build.outputs.tags }}with line-safe iteration over an env-provided multiline string.Workflow loop hardening (
sign,provenance,verify)TAGSenv wiring fromneeds.build.outputs.tags.printf '%s\n' "$TAGS" | while IFS= read -r tag; do ...; done.Shell interpolation safety + output cleanup
ref_name,ref_type, repo/ref) into stepenvvariables before command use.versionto$GITHUB_OUTPUT.Supply-chain verification/provenance tightening
cosign verifynow pins certificate identity to this exact workflow and ref.buildTypenow includes workflow ref (@${GITHUB_REF}) for versioned provenance identity.