memoryscraper cleanup#1773
Open
Akshay2191 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3-refactoring #1773 +/- ##
==================================================
+ Coverage 84.78% 84.89% +0.11%
==================================================
Files 105 105
Lines 13656 13660 +4
==================================================
+ Hits 11578 11597 +19
+ Misses 1557 1540 -17
- Partials 521 523 +2
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Akshay2191
force-pushed
the
memoryscraper-cleanup
branch
from
b5d8cb0 to
c1ea8e5
Compare
karensantana
reviewed
Jul 2, 2026
| cgroupStat.Shared = memoryStat.shared | ||
| cgroupStat.UsedPercent = usedMemoryPercent | ||
| cgroupStat.Free = memoryLimitInBytes - usedMemory | ||
| cgroupStat.Free = saturatingSub(memoryLimitInBytes, usedMemory) |
Contributor
There was a problem hiding this comment.
comment(non-blocking): I know this was not introduced in this PR, however it is interesting that Free and Available are holding the same value (and the metrics tests are passing). According to AI these values are not the same. 🤔
karensantana
approved these changes
Jul 2, 2026
craigell
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.