bump aws-lc-sys/aws-lc-rs to fix Windows CI#204
Closed
bmpngrok wants to merge 1 commit into
Closed
Conversation
Builds were failing on Windows with cmake-0.1.54/src/lib.rs:970: couldn't determine visual studio generator i.e. cmake-rs 0.1.54 doesn't recognise Visual Studio 18 (now on windows-latest); cmake-rs 0.1.57+ does, and aws-lc-sys 0.28.2 is happy to drive the newer cmake-rs.
bmpngrok
force-pushed
the
bmps/push-yprqprqqoloo
branch
from
f30750b to
9dbacb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-lc-sys 0.28.2 fails its C11 atomics feature check against MSVC 14.50 on the current windows-latest runner:
0.40.0 ships fixes for the newer MSVC toolchain (and drops the
bindgen build-time dependency).
Also bumped aws-lc-rs in lockstep.
Related Pull Requests
This pull request is part of a stack managed by jj-domino: