Fade out PRs that leave the results before removing them - #1
Draft
nice-jan-p wants to merge 1 commit into
Draft
Conversation
Previously a PR that was merged/closed vanished from the table abruptly on the next poll. Now a disappeared PR is kept on screen briefly, flagged `_removing`, and faded out via a CSS animation before it's dropped. The diff/merge logic is extracted into a pure `reconcileRows` helper with tests; fade-out timers are cancelled if a PR reappears and cleared on unmount. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fade out PRs that leave the results before removing them
Possible impact: PR dashboard table rendering, polling/sync behavior
Summary
_removing, and faded out with a CSS animation before it is actually dropped from the list.Changes
reconcileRows.ts(new): pure helper that diffs the previously-displayed rows against a fresh fetch, keeps disappeared PRs flagged_removing, and returns the merged list (sorted newest-first) plus the keys currently fading out.usePolling.ts: usesreconcileRowson each sync; schedules the real removal after the fade (FADE_OUT_MS = 600), cancels a pending fade-out if the PR reappears, replaces wholesale on a filter change (no fade), and clears timers on unmount.PullRequestTable.tsx: applies apr-row--removingclass viagetRowClassNamewith a 600ms opacity fade-out keyframe.reconcileRows.test.ts(new): unit tests for the diff/merge/sort behavior.Test Plan
tsc --noEmitpassesvitest run— 23 tests pass (5 new)vite buildsucceeds🤖 Generated with Claude Code