Conversation
…holder syntax - Remove 2 test blocks referencing non-existent "slate" theme from theme-switching.test.tsx - Fix CommandInput placeholder to use correct lsd: prefix pattern - Both fixes identified in deep review before merge/release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a major theming system refactor for LSD v1.1.0, transitioning from shadcn-style theme variables to pure LSD design tokens with improved semantic clarity, enhanced light/dark variants support, and reorganized theme structure.
Breaking Changes 🚨
Complete Theme Variable Migration
Removed shadcn-style variables:
--background,--foreground--primary,--primary-foreground--secondary,--secondary-foreground--accent,--accent-foreground--destructive,--destructive-foreground--muted,--muted-foreground--border,--input,--ringRenamed to LSD design tokens:
text-lsd-text-secondary) → Single prefix (text-secondary)Variable name updates:
text-primary→text-neutralsurface→backgroundtext-decorative→text-secondaryFeatures ✨
Enhanced Theme Architecture
core.cssto explicit[data-theme="monochrome"]inthemes.cssfor consistent data-theme support&.lightand&.darkvariantsComponent Enhancements
triggerStyleprop for inline styling withcn()className merging supportDocumentation Improvements
colours→colorsMigration Guide 📋
If you have custom themes or override theme variables, you'll need to update them:
Replace shadcn-style variables with LSD tokens
Update variable naming to single-prefix pattern
Review custom theme definitions against the new theme structure in
packages/lsd/src/styles/themes.cssNote: The 5 themes (monochrome, teal, nord, terracotta, catppuccin) that existed in v1.0.0 are still available, but with improved structure and variable naming.
Testing 🧪
Bug Fixes 🐛
lsd:prefixQuality Improvements
lsd:prefix usage across all componentsFiles Changed
packages/lsd/src/styles/themes.css(theme restructuring)packages/lsd/src/styles/core.css(shadcn var removal)packages/lsd/src/styles/sonner.css(variable updates)Checklist
Release Notes
This change requires users upgrading from v1.0.0 to update any custom theme definitions or variable overrides. The new theming system provides better semantic clarity, cleaner architecture by removing shadcn-ui compatibility layer, and enhanced support for nested light/dark theme variants with existing accent themes.