Skip to content

build: re-export FastResponse and srvx types #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schplitt wants to merge 4 commits into
base: main
Choose a base branch
from
Open

build: re-export FastResponse and srvx types #4499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5d4cf9
feat: add srvx module re-export
schplitt Jul 30, 2026
a1209b6
fix: adjust exports to be non breaking
schplitt Jul 30, 2026
dbb3ad8
fix: remove ServerRequest type export from `nitro` subpath
schplitt Jul 30, 2026
d05d202
fix: remove duplicate exports
schplitt Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/runtime/nitro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ export {
} from "h3";
export type { H3Event, EventHandlerRequest, EventHandlerWithFetch } from "h3";

// srvx
export type { FastResponse, FastURL } from "srvx";

@coderabbitai coderabbitai Bot Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Keep srvx context exports consistent across Nitro entry points.

Removing ServerRequest matches the PR objective, but this entry point still omits ServerRequestContext and ServerRuntimeContext, which are exposed by src/types/srvx.ts and used by Nitro’s request APIs. Consumers importing Nitro types from this module cannot access the complete srvx contract.

At minimum, re-export the context types here, or confirm that they are intentionally declaration-only and adjust the public typing contract accordingly.

#!/bin/bash
rg -n -C 3 '\b(ServerRequestContext|ServerRuntimeContext|serverFetch)\b' src
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/runtime/nitro.ts` at line 27, Update the srvx type re-exports in the
Nitro entry point to include ServerRequestContext and ServerRuntimeContext
alongside FastResponse and FastURL. Keep ServerRequest removed, and ensure
consumers importing types from this module receive the complete supported srvx
contract.


// Runtime
export function serverFetch(
resource: string | URL | Request,
Expand Down
6 changes: 5 additions & 1 deletion src/types/srvx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
export type { ServerRequest } from "srvx";
export type {
ServerRequest,
ServerRequestContext,
ServerRuntimeContext,
} from "srvx";