fix(vite): subscribe rollup:reload to hot-reload after updateConfig - #4503
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe Vite development server now invokes its debounced reload workflow on Nitro ChangesVite development reload updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/vite/update-config.test.ts`:
- Line 27: Restore the original process working directory after the test setup
that calls process.chdir(rootDir), ensuring cleanup runs after the affected
tests complete so later tests are not left resolving paths from the fixture
directory.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 65368265-b9c3-4233-a67c-52ae3a93f00f
📒 Files selected for processing (2)
src/build/vite/dev.tstest/vite/update-config.test.ts
🔗 Linked issue
❓ Type of change
📚 Description
spotted in nuxt - calling
updateConfigdid nothing when using withnitro/vite.📝 Checklist