fix(build): escape dynamic route segments in chunk names - #4508
Open
RezaRahemtola wants to merge 1 commit into
Open
fix(build): escape dynamic route segments in chunk names#4508RezaRahemtola wants to merge 1 commit into
RezaRahemtola wants to merge 1 commit into
Conversation
|
@RezaRahemtola is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesRoute chunk encoding
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
getChunkNamereturns_routes/<path>.mjsfor route handlers, androuteToFsPathconverts dynamic segments like:idto[id]. Rollup rejects[id]as an invalidchunkFileNamesplaceholder, so building with the Rollup builder fails on nested dynamic routes likeserver/api/applications/[id]/context.get.ts.It looks like Rolldown (the default builder) tolerates the brackets, which is why this slipped through.
This PR encodes brackets (
[and]) as%5B/%5Din the chunk name so it's a validchunkFileNamespattern.This also avoids any collision with literal route segments named
_id_(the concern that closed the similar PR I found #4393).Also updated the unit test and added a nested dynamic route case.
📝 Checklist