feat(fairway): the premium facelift — every coach screen as a field sheet

[njrini99-code]

What this is

The Fairway premium facelift for the coach side of GolfHelm. Every coach screen was a masthead sitting on a deck of rounded cream boxes. The owner's words were that it looked basic and like the product was going backwards. This branch replaces that idiom with a written page language and rebuilds each screen against it.

Do not merge yet. This is opened for review at the owner's request.

The page language

docs/design/fairway-facelift/LANGUAGE.md is binding, and every screen spec cites it. One anatomy, in DOM order:

1. A bare masthead on the canvas. No plinth. A verdict sentence built only from real fields, with names as links.
2. Exactly one Surface, holding one real instrument.
3. A bare ledger row of unequal, hairline-divided columns.
4. A dense table.

Green is ink. Amber means over par or urgent. Nothing else is coloured.

Two rules earned their place the hard way and are worth reading before reviewing:

No dot-on-a-rail. A mark sitting on a full-width rail reads as a handle parked on a slider. Instruments use vertical ground, or a zero rule that marks genuinely rise above and fall below, or no ground at all. Every mark states its own value in mono beside it rather than asking the reader to measure it against a distant axis. The component that embodied the old pattern, StandingTrack, is deleted here.

The breakpoint rule is a floor, not a number. A split is legal only at the width where every column still holds its content whole. A fixed rail beside a flexible instrument may not split before xl. A fractional split shares the loss and may sit lower, but must be captured there. Verified at 768, 1024, 1280 and 1440, and on a phone.

Screens rebuilt

Coach home, calendar, roster, player detail, rounds library, round review, qualifiers, team stats, tasks and intelligence. Each has a spec under docs/design/fairway-facelift/screens/*.v3.md with a ## Result section recording every deviation and why.

Correctness fixes found along the way

These are not cosmetic. Each was a number or a sentence that lied.

• A readout claimed "44.5 pts" over five rounds that were five unrelated single rounds by different players. Team headlines now aggregate into buckets the way the headline itself claims.
• A sparkline's colour contradicted its own caption. The caption used a split-half average and the sparkline recomputed from endpoints. They now share one computation.
• Two columns on the roster both read "Avg" and disagreed by three strokes, because one averaged the selected window and the other the whole career.
• StandingBars clipped its own reference label to "Fiel…" everywhere it rendered, hiding which reference the bar was measured against.
• The stored round narrative said "0 pars" for scorecard-only rounds, deriving a hole-by-hole fact from no holes at all.
• A truncating name could not shrink inside ScoreField's identity track. truncate sets white-space: nowrap, which makes a flex item's minimum size its whole unbroken line.

Defence against real production data

Two golf_qualifiers rows carry a start_date in the year 60824, which a date column accepts. Plotted, they stretched the axis across roughly fifty-eight thousand years, collapsed every real bar to a hairline, and drove a monthly tick loop through about seven hundred thousand iterations. DOMAIN_LIMIT_YEARS and isPlottable keep such a row out of the domain and render it as "Dates outside the plotted range" instead of a bar, and MAX_TICK_STEPS in ScoreField is the backstop for any caller that forgets to bound its own domain. The rows themselves are still wrong and still there.

Mobile

Mobile is in scope. A wide table at 390px either scrolls sideways or truncates the column that identifies the row. Screens render two branches, a stacked list and the table, both always in the DOM with CSS choosing between them, so no breakpoint is read at runtime and the server render and first client paint agree.

Two things a reviewer should know before reading the history

1. Two commits titled as docs changes carry source deletions. 02a9266fd and 82ce0ab49 swept up files because staging was too broad. 02a9266fd deleted the player's round row component and its test, which is a real mistake: an implementer then built on a tree where the player's row had vanished, so the coach's dense table briefly rendered for players too. Both the component and its test are restored, and the role branch is fixed. A third, 83d72a570, looks alarming at twenty-nine files but is the intended dead-code sweep, recorded afterwards in 77927200e.
2. The Ask CoachHelm launcher sits on top of page content in the bottom-right corner at every scroll position, including over a readout on the coach home. It is pinned to the viewport, so page padding cannot clear a row in the middle of a scrolling list. Fixing it means changing the launcher, which is a product decision and is deliberately not made here.

Verification

Per-screen: scoped vitest, eslint on changed files, and desktop and phone captures read at full size at each of the four desktop widths and on a phone. Feature docs updated through npm run knowledge:map. Repo-wide route-reachability and storage-buckets-tracked were red and are addressed; the remaining reachability entries are CoachHelm components orphaned by the intelligence rebuild.

Full typecheck, lint and build run under the required GitHub checks on this branch.

Still landing

Several implementers are still committing into this branch, so expect further commits on the same PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_011zGybqwusmeKC2jJhsU9JC