Repository navigation
fix(docker-build): tag and sign only after the Trivy scan passes - #91
Merged
Merged
Conversation
…asses The build pushed with its tags and then gated, so a failed scan had already moved latest. Push by digest, scan the digest, then apply the tags with imagetools create; cosign moves below the scan as well. Fixes #87 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5bjKagyEioaHuJicZbyvm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87.
Problem
docker-build.ymlpushed the image with all its tags, then ran the failing Trivy scan. A red gate still left the rejected image live underlatestand the branch tag.Change
push-by-digest=true, no tags).docker buildx imagetools create, and asserts each tag resolves to the scanned digest.No input or output changes.
push: falsestill builds without publishing. Callers withrun-trivy-scan: falseget the same tags as before.Verification
actionlintandyamllintpass locally.self-test.ymlhas no docker-build job and there is no local Docker. Before cutting a release, point one consumer (for exampleHordiaLabs/extractor-llm) at this branch and confirm the tags land andcosign verifystill passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01C5bjKagyEioaHuJicZbyvm