Update CBOR references and half-float assertion bounds - #5335
Merged
Conversation
Signed-off-by: Patrick Armstrong <patrick@erpassistant.ai>
Owner
|
Thanks! |
|
Happy to help out! I'll keep poking around and see if there's anything else i can do. /commented using the wrong account |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
The decoder masks the exponent with
0x1Fand the mantissa with0x3FF, so their maximum values are 31 and 1023. The previous bounds of 32 and 1024 could never be reached.RFC 8949 obsoletes RFC 7049. The existing Appendix D, Figure 3 citation remains valid in RFC 8949. This change corrects debug invariants and stale references without changing CBOR encoding or decoding behavior.
Testing
cmake --build build --paralleltest-cbor_cpp11passed.2e2368709.single_include/nlohmann/json.hpp.Closes #5319