fix: check CBOR tagged subtype reads - #5339
Merged
nlohmann merged 2 commits intoJul 31, 2026
Merged
Conversation
Signed-off-by: ahmadalguydi <ahmadalgaidy@hotmail.com>
nlohmann
requested changes
Jul 31, 2026
nlohmann
left a comment
nlohmann
left a comment
Owner
There was a problem hiding this comment.
The logics looks good, but the amalgamation is wrong. Please re-amalgamate by running make amalgamate.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: ahmadalguydi <ahmadalgaidy@hotmail.com>
tomatotomata
marked this pull request as ready for review
July 31, 2026 09:29
Contributor
Author
|
I applied the repository's amalgamation patch from the failed check and pushed 2f31abf. That refreshes single_include/nlohmann/json.hpp and the affected regression-test formatting, with git diff --check clean. The PR is ready for another look; let me know what you think. |
nlohmann
added
the
🚀 ready to merge
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5338\n\nThe CBOR tagged-binary subtype branches now propagate failed get_number() reads before using the subtype, for both the ignore and store handlers. The regression suite covers truncated 1-, 2-, 4-, and 8-byte subtype tags in both modes. The amalgamated single header was regenerated as required by the project.\n\nVerification:\n- git diff --check passes\n- Static inspection confirms all eight tagged subtype reads now check their return values\n- C++ tests could not be run in this Windows environment because no compiler or CMake is installed