[Hotfix] change the default era to NULL in multiple functions#236
Open
Schiano-NOAA wants to merge 4 commits intomainfrom
Open
[Hotfix] change the default era to NULL in multiple functions#236Schiano-NOAA wants to merge 4 commits intomainfrom
Schiano-NOAA wants to merge 4 commits intomainfrom
Conversation
Contributor
New version checklist
|
| recruitment_label = "mt", | ||
| interactive = TRUE, | ||
| # era = "time", | ||
| era = "time", |
Collaborator
There was a problem hiding this comment.
Should this be NULL, just like for the other plotting functions?
Collaborator
Author
There was a problem hiding this comment.
No I had set it NULL but it made the tests fail so something is wack when it's set to NULL
Collaborator
There was a problem hiding this comment.
Do you know what's unexpectedly happening? It's strange that everything else works when this argument is set consistently, except for this one
Collaborator
Author
There was a problem hiding this comment.
I think in this case, it needs era = "time" because it has that in the values? But I would have to look into it to be sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting default era to NULL instead of "time" so nothing is unnecessarily filtered by default