chore(deps): regenerate package-lock for npm 10 compatibility - #330
Merged
Conversation
…m ci compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core's package-lock.json was regenerated under npm 11 during the v1.20.1 release; npm 10 (bundled with node 20/22) rejects it:
npm cifails with "Missing: conventional-commits-parser@6.4.0 from lock file" — git-raw-commits declares an optional peerDependency npm 11 skips but npm 10 requires recorded.Regenerated with npm 10 (
npx npm@10 install): records the nestedgit-raw-commits/node_modules/conventional-commits-parser@6.4.0entry (+19/−30 lines). Verified:npm cipasses under BOTH npm 10.9 and npm 11.17; full Jest suite 2232/2232 green; build unchanged.Unblocks the Elements e2e CI job (nojs-elements#81), which clones and
npm cis this repo on node 22. Surfaced by no-js-dev/nojs-elements#80 CI work.