Skip to content

docs: refer to "squash" in help screen for git node land#1108

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
sxa:fixup=squash
Jul 1, 2026
Merged

docs: refer to "squash" in help screen for git node land#1108
aduh95 merged 1 commit into
nodejs:mainfrom
sxa:fixup=squash

Conversation

@sxa

@sxa sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member

Since this is my first contribution to NCU I'll note that npm run test-all as documented in the contributing guide doesn't seem to be valid. I have run npm test on this though. Based on the fact it looks like the target was removed in #670 I'll submit a follow on PR to remove that step from the guide.

This change is because I was looking for the option on git node land to squash commits when landing nodejs/node#64193 (which I was pretty sure I'd used on the past) but it doesn't have squash in the help screen as it's named fixupAll and this will allow git node land --help | grep squash to find it. I may also add a reference to this as a recommendation in the main node collaborator guide if people thing that's appropriate.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (2d1085f) to head (1dd68d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1108   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files          45       45           
  Lines        7003     7003           
=======================================
  Hits         4519     4519           
  Misses       2484     2484           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread components/git/land.js Outdated
Signed-off-by: Stewart X Addison <sxa@ibm.com>
@sxa

sxa commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Force push to squash as there was a linter error when I accepted @Renegade334's suggested change related to the Co-authored-by line that was added.

@aduh95 aduh95 merged commit ce38c70 into nodejs:main Jul 1, 2026
11 checks passed
@sxa sxa deleted the fixup=squash branch July 1, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants