Skip to content

repl: fix dedup comparing normalized line against raw history#62886

Open
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:fixes-repl
Open

repl: fix dedup comparing normalized line against raw history#62886
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:fixes-repl

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Apr 22, 2026

This ensures consistency in how the REPL history handles duplicate entries.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.63%. Comparing base (d44a71a) to head (a271a72).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62886      +/-   ##
==========================================
+ Coverage   89.61%   89.63%   +0.01%     
==========================================
  Files         706      706              
  Lines      219203   219203              
  Branches    41995    42001       +6     
==========================================
+ Hits       196445   196472      +27     
+ Misses      14663    14630      -33     
- Partials     8095     8101       +6     
Files with missing lines Coverage Δ
lib/internal/repl/history.js 93.62% <100.00%> (ø)

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watilde
Copy link
Copy Markdown
Member Author

watilde commented Apr 23, 2026

rebase and make the commit Verified.

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. request-ci Add this label to start a Jenkins CI on a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants