deps: fix V8 build failures by adding climits include#63287
Open
tjuhaszrh wants to merge 1 commit into
Open
Conversation
Add explicit #include <climits> to memcopy.h to fix build failures caused by recent GCC/Clang versions removing transient inclusions of the climits header. Fixes compilation errors when using newer toolchain versions.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Renegade334
requested changes
May 13, 2026
gnomesysadmins
pushed a commit
to GNOME/gnome-build-meta
that referenced
this pull request
Jun 6, 2026
This fixes a build failure seen on aarch64 with GCC 16. The cause is a mistake in the V8 JavaScript engine, previously masked because the <climits> header was included transiently in previous versions of GCC. The patch added here is taken from a PR against NodeJS: <nodejs/node#63287> The NodeJS owners haven't merged the PR because they're waiting for a fix to land upstream in V8 instead.
github-actions Bot
pushed a commit
to castrojo/freedesktop-sdk
that referenced
this pull request
Jun 26, 2026
The patch comes from nodejs workarounding it internally because chromium hasn't addressed it yet. nodejs/node#63287 https://issues.chromium.org/issues/512749476
gnomesysadmins
pushed a commit
to GNOME/gnome-build-meta
that referenced
this pull request
Jun 26, 2026
This fixes a build failure seen on aarch64 with GCC 16. The cause is a mistake in the V8 JavaScript engine, previously masked because the <climits> header was included transiently in previous versions of GCC. The patch added here is taken from a PR against NodeJS: <nodejs/node#63287> The NodeJS owners haven't merged the PR because they're waiting for a fix to land upstream in V8 instead.
github-actions Bot
pushed a commit
to castrojo/freedesktop-sdk
that referenced
this pull request
Jun 26, 2026
The patch comes from nodejs workarounding it internally because chromium hasn't addressed it yet. nodejs/node#63287 https://issues.chromium.org/issues/512749476
gnomesysadmins
pushed a commit
to GNOME/gnome-build-meta
that referenced
this pull request
Jun 26, 2026
This fixes a build failure seen on aarch64 with GCC 16. The cause is a mistake in the V8 JavaScript engine, previously masked because the <climits> header was included transiently in previous versions of GCC. The patch added here is taken from a PR against NodeJS: <nodejs/node#63287> The NodeJS owners haven't merged the PR because they're waiting for a fix to land upstream in V8 instead.
gnomesysadmins
pushed a commit
to GNOME/gnome-build-meta
that referenced
this pull request
Jun 27, 2026
This fixes a build failure seen on aarch64 with GCC 16. The cause is a mistake in the V8 JavaScript engine, previously masked because the <climits> header was included transiently in previous versions of GCC. The patch added here is taken from a PR against NodeJS: <nodejs/node#63287> The NodeJS owners haven't merged the PR because they're waiting for a fix to land upstream in V8 instead.
gnomesysadmins
pushed a commit
to GNOME/gnome-build-meta
that referenced
this pull request
Jun 29, 2026
This fixes a build failure seen on aarch64 with GCC 16. The cause is a mistake in the V8 JavaScript engine, previously masked because the <climits> header was included transiently in previous versions of GCC. The patch added here is taken from a PR against NodeJS: <nodejs/node#63287> The NodeJS owners haven't merged the PR because they're waiting for a fix to land upstream in V8 instead.
gnomesysadmins
pushed a commit
to GNOME/gnome-build-meta
that referenced
this pull request
Jun 29, 2026
This fixes a build failure seen on aarch64 with GCC 16. The cause is a mistake in the V8 JavaScript engine, previously masked because the <climits> header was included transiently in previous versions of GCC. The patch added here is taken from a PR against NodeJS: <nodejs/node#63287> The NodeJS owners haven't merged the PR because they're waiting for a fix to land upstream in V8 instead.
github-actions Bot
pushed a commit
to castrojo/freedesktop-sdk
that referenced
this pull request
Jun 29, 2026
The patch comes from nodejs workarounding it internally because chromium hasn't addressed it yet. nodejs/node#63287 https://issues.chromium.org/issues/512749476
github-actions Bot
pushed a commit
to castrojo/freedesktop-sdk
that referenced
this pull request
Jun 29, 2026
The patch comes from nodejs workarounding it internally because chromium hasn't addressed it yet. nodejs/node#63287 https://issues.chromium.org/issues/512749476
github-actions Bot
pushed a commit
to castrojo/freedesktop-sdk
that referenced
this pull request
Jun 30, 2026
The patch comes from nodejs workarounding it internally because chromium hasn't addressed it yet. nodejs/node#63287 https://issues.chromium.org/issues/512749476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit #include to memcopy.h to fix build failures caused by recent GCC/Clang versions removing transient inclusions of the climits header.
Fixes compilation errors when using newer toolchain versions.
Without this change the build fails with following error on aarch64:
Refs: #63146