Skip to content

test: fix typos in comments#63403

Closed
parkhojeong wants to merge 2 commits into
nodejs:mainfrom
parkhojeong:fix/test-comment-typos
Closed

test: fix typos in comments#63403
parkhojeong wants to merge 2 commits into
nodejs:mainfrom
parkhojeong:fix/test-comment-typos

Conversation

@parkhojeong

Copy link
Copy Markdown
Contributor

Fixes typos in test comments.

  • funciton -> function
  • overriden -> overridden

Signed-off-by: parkhojeong <parkhj062@gmail.com>
Signed-off-by: parkhojeong <parkhj062@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 18, 2026
@parkhojeong parkhojeong marked this pull request as ready for review May 18, 2026 07:03
@parkhojeong

parkhojeong commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

@lpinca @deokjinkim
Hi, This seems ready to be merged. could you please merge this PR?

@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@parkhojeong

Copy link
Copy Markdown
Contributor Author

@deokjinkim
https://ci.nodejs.org/job/node-test-pull-request/74304/
The CI failed, but I don't have permission to access it. Could you take a look?

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau richardlau added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 24, 2026
@deokjinkim deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 6f11fe7...5b2b138

nodejs-github-bot pushed a commit that referenced this pull request Jun 24, 2026
Signed-off-by: parkhojeong <parkhj062@gmail.com>
PR-URL: #63403
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jun 24, 2026
Signed-off-by: parkhojeong <parkhj062@gmail.com>
PR-URL: #63403
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@deokjinkim

Copy link
Copy Markdown
Contributor

@deokjinkim https://ci.nodejs.org/job/node-test-pull-request/74304/ The CI failed, but I don't have permission to access it. Could you take a look?

@parkhojeong As you know, your PR is not related to CI failure. Thanks to @richardlau 's help, CI got green and landed your PR. Thank you for your contribution.

@parkhojeong

Copy link
Copy Markdown
Contributor Author

@deokjinkim @richardlau

Looks like it’s done. Thanks!

luanmuniz pushed a commit to luanmuniz/node that referenced this pull request Jun 25, 2026
Signed-off-by: parkhojeong <parkhj062@gmail.com>
PR-URL: nodejs#63403
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
luanmuniz pushed a commit to luanmuniz/node that referenced this pull request Jun 25, 2026
Signed-off-by: parkhojeong <parkhj062@gmail.com>
PR-URL: nodejs#63403
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants