-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
module: add tests for two cases of eager imports: #64197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MayaLekova
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
MayaLekova:import-defer-02
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Flags: --js-defer-import-eval | ||
|
|
||
| // Tests that defer import of a module with top-level await | ||
| // eagerly evaluates the imported module. | ||
|
|
||
| import '../common/index.mjs'; | ||
| import * as assert from 'assert'; | ||
|
|
||
| // The importing module will only execute once its dependency containing | ||
| // top-level await has its promises resolved, as per | ||
| // https://github.com/tc39/proposal-top-level-await#what-exactly-is-blocked-by-a-top-level-await | ||
| if (!globalThis.eval_list) { | ||
| globalThis.eval_list = []; | ||
| } | ||
|
|
||
| import defer * as ns from '../fixtures/es-modules/dep-module-top-level-await.mjs'; | ||
|
|
||
| // Check that the module has already been evaluated. | ||
| assert.strictEqual(globalThis.eval_list.length, 1); | ||
| assert.strictEqual(ns.foo, 42); | ||
| assert.partialDeepStrictEqual(['defer-tla-1'], globalThis.eval_list); | ||
|
|
||
| // Clean-up | ||
| delete globalThis.eval_list; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Flags: --js-defer-import-eval | ||
|
|
||
| // Tests that defer import of a module that is also eagerly imported | ||
| // from another dependency gets executed synchronously, and gets | ||
| // executed exactly once. | ||
|
|
||
| import '../common/index.mjs'; | ||
| import * as assert from 'assert'; | ||
|
|
||
| if (!globalThis.eval_list) { | ||
| globalThis.eval_list = []; | ||
| } | ||
|
|
||
| import * as non_deferred from '../fixtures/es-modules/module-with-module-tree.mjs'; | ||
| import defer * as deferred from '../fixtures/es-modules/module-deferred-eval.mjs'; | ||
|
|
||
| // Check that the module has been evaluated exactly once. | ||
| assert.strictEqual(globalThis.eval_list.length, 1); | ||
| assert.strictEqual(deferred.foo, 42); | ||
| assert.partialDeepStrictEqual(['defer-1'], globalThis.eval_list); | ||
|
|
||
| // Clean-up | ||
| delete globalThis.eval_list; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { setTimeout } from 'node:timers/promises'; | ||
|
|
||
| if (!globalThis.eval_list) { | ||
| globalThis.eval_list = []; | ||
| } | ||
| globalThis.eval_list.push('defer-tla-1'); | ||
|
|
||
| export const foo = 42; | ||
|
|
||
| await setTimeout(1); | ||
| console.log('executed'); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this also push to |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also assert the length after the
ns.fooaccess.