errors: trace unhandled promise rejection location#64201
Closed
legendecas wants to merge 1 commit into
Closed
Conversation
bc40f2b to
e8c692b
Compare
Print where an unhandled promise is been rejected with flag `--trace-uncaught`. This also locates the rejection site when a promise is rejected with a primitive values. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
e8c692b to
4535857
Compare
Member
Author
|
There are a few cases where V8 calls PromiseRejectCallback not at where the promise is rejected. Might need to fix in V8 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print where an unhandled promise is been rejected with flag
--trace-uncaught. This also locates the rejection site when a promiseis rejected with a primitive values.
For example, when an error is constructed at a place that's different
from where it is thrown,
--trace-uncaughtwould print the locationwhere it is thrown.