meta: clarify --harmony features are outside threat model#64224
Open
mcollina wants to merge 1 commit into
Open
meta: clarify --harmony features are outside threat model#64224mcollina wants to merge 1 commit into
mcollina wants to merge 1 commit into
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Collaborator
|
Review requested:
|
ShogunPanda
approved these changes
Jul 1, 2026
panva
approved these changes
Jul 1, 2026
marco-ippolito
approved these changes
Jul 1, 2026
Renegade334
reviewed
Jul 1, 2026
Comment on lines
+147
to
+148
| Node.js may expose V8 features that are controlled by `--harmony` flags | ||
| (e.g., `--harmony-optional-chaining`, `--harmony-shadowrealm`). These flags |
Member
There was a problem hiding this comment.
--harmony is deprecated terminology in V8, and new features haven't used it for some time. I would suggest something like
Node.js may expose in-development V8 features that are only available via
--js-*or--harmony-*runtime flags (e.g.,--js-decorators,--harmony-shadowrealm).
--js-staging is the new global flag equivalent of --harmony.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot be responsible for V8 experimental features in case they cause security problems.