fs: fix close listener leak in FileHandle streams#64227
Open
Y1D7NG wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
fs
Y1D7NG
force-pushed
the
fix-stream-leak
branch
5 times, most recently
from
b433fb3 to
c4a165a
Compare
Fixes: nodejs#64214 Signed-off-by: y1d7ng <y1d7ng@yeah.net>
davidje13
reviewed
Jul 1, 2026
Comment on lines
+51
to
+58
| for (let i = 0; i < 11; i++) { | ||
| await buffer(fileHandle.createReadStream({ | ||
| start: i, | ||
| end: i, | ||
| autoClose: false, | ||
| })); | ||
| assert.strictEqual(fileHandle.listenerCount('close'), 0); | ||
| } |
There was a problem hiding this comment.
this doesn't need to be in a loop - I just used a loop in my report to demonstrate that it would trigger MaxListenersExceededWarning, but checking listenerCount = 0 after a single read stream is enough for a test (maybe 2, to prove the handle is still open for creating a second stream)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #64214
When autoClose is false, FileHandle.createReadStream registers a close listener on the handle. That listener is not removed after the stream finishes normally, so creating streams repeatedly on the same handle accumulates listeners.
In importFd, when autoClose is false, remove that listener and perform the corresponding unref cleanup when the stream ends (on end for read streams, on finish for write streams) or on error.