sqlite: add StatementSync.prototype[Symbol.dispose]()#64232
Open
araujogui wants to merge 1 commit into
Open
Conversation
This extends explicit resource management support to prepared statements, allowing a StatementSync to be deterministically finalized via a `using` declaration, mirroring the existing DatabaseSync and Session dispose methods. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
There was a problem hiding this comment.
Pull request overview
Adds support for explicit resource management on StatementSync by implementing StatementSync.prototype[Symbol.dispose]() so prepared statements can be deterministically finalized (including via using declarations), aligning StatementSync with other sqlite objects that already support Symbol.dispose.
Changes:
- Implement
StatementSync::Dispose()and wire it up viaSetProtoDispose(...). - Refactor statement cleanup into a shared
StatementSync::Close()used by both the destructor andSymbol.dispose. - Add tests and API documentation for
statement[Symbol.dispose]()behavior (idempotent finalize, post-finalize errors,usingintegration).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/parallel/test-sqlite-statement-sync.js | Adds coverage for StatementSync disposal semantics and using integration. |
| src/node_sqlite.h | Declares StatementSync::Dispose() and introduces a private Close() helper. |
| src/node_sqlite.cc | Implements disposal/close behavior, hooks Symbol.dispose, and simplifies statement untracking. |
| doc/api/sqlite.md | Documents the new statement[Symbol.dispose]() API and its no-op behavior when already finalized. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.