Skip to content

child_process: keep SIGWINCH from killing on Win - #64510

Open
PickBas wants to merge 1 commit into
nodejs:mainfrom
JaneaSystems:issue-64324
Open

child_process: keep SIGWINCH from killing on Win#64510
PickBas wants to merge 1 commit into
nodejs:mainfrom
JaneaSystems:issue-64324

Conversation

@PickBas

@PickBas PickBas commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

child_process: keep SIGWINCH from killing on Win

On Windows, ProcessWrap::Kill coerced any signal outside {SIGKILL, SIGTERM, SIGINT, SIGQUIT, 0} to SIGKILL. This wrongly terminated a process on kill('SIGWINCH'), a non-terminal signal.

SIGWINCH now skips the coercion and reaches libuv, which returns UV_ENOSYS, surfaced as an ENOSYS error in JS, leaving the target process alive.

Fixes: #64324

Fixes: nodejs#64324
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (4140d4c) to head (9d89021).
⚠️ Report is 551 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64510      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.02%     
==========================================
  Files         741      739       -2     
  Lines      241216   241669     +453     
  Branches    45442    45548     +106     
==========================================
+ Hits       217713   218093     +380     
- Misses      15079    15110      +31     
- Partials     8424     8466      +42     
Files with missing lines Coverage Δ
src/process_wrap.cc 75.00% <ø> (ø)

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subprocess.kill('SIGWINCH') forcefully terminates subprocesses on Windows

3 participants